Review Request 115708: Build on Mac OS X
Luigi Toscano
luigi.toscano at tiscali.it
Wed Feb 12 22:56:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115708/#review49682
-----------------------------------------------------------
Ship it!
It seems to work correctly, so ship it from my side.
I have no idea about Windows and I don't have the resources to test it, but I hope this will be checked.
- Luigi Toscano
On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115708/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 9:46 p.m.)
>
>
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> On Mac OS X, the binary is in docbookl10nhelper.app/..., so let cmake substitute the actual binary instead of hard-coding it. Should also fix the build on windows, where the executable has a .exe suffix
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a
>
> Diff: https://git.reviewboard.kde.org/r/115708/diff/
>
>
> Testing
> -------
>
> Building on Mac OS X
>
>
> Thanks,
>
> Harald Fernengel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140212/f372ccc2/attachment.html>
More information about the Kde-frameworks-devel
mailing list