Review Request 115699: Build on Mac OS X

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115699/#review49653
-----------------------------------------------------------

Ship it!


yeah Atom is an XLib data type.

I plan to make all our frameworks to compile without X11 (just did that for plasma-framework) and get sysadmins to install variations on build.kde.org to ensure that it doesn't break. We already have that for kwindowsystem.

- Martin Gräßlin


On Feb. 12, 2014, 2:15 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115699/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Fix the case where X11 is not available at compile time. 'Atom' seems to be X11-only? Also, KStartupInfo is required even on non-X11 builds.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kapplication.cpp 47e4983c7392a0d60036ae86d976ae689a40d54a 
>   src/kdeui/kmenubar.cpp f2dc2b1b3d22fa38cfe6af4a7761c148f840620d 
> 
> Diff: https://git.reviewboard.kde.org/r/115699/diff/
> 
> 
> Testing
> -------
> 
> Compiles on Mac OS X.
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140212/bd7cf4a3/attachment.html>