Review Request 115653: Introduce a showOnCurrentPlatform method to KService

David Faure faure at kde.org
Wed Feb 12 07:22:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115653/#review49622
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 12, 2014, 7:12 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115653/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 7:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Introduce a showOnCurrentPlatform method to KService
> 
> This is inspired by showInKDE to easily exclude modules which doesn't
> make any sense on the current platform. E.g. in systemsettings we
> do not want services which are X11 specific if systemsettings is
> executed on Wayland.
> 
> 
> Diffs
> -----
> 
>   src/services/kservice.cpp 1da29e2629c09a150acee977237a25924056e3bc 
>   src/services/kservice.h 6bc1bb988b273c9b2e6593f5f517535701b3854d 
> 
> Diff: https://git.reviewboard.kde.org/r/115653/diff/
> 
> 
> Testing
> -------
> 
> Added "OnlyShowOnPlatforms=xcb;" to kcmbell's desktop file. Shown in systemsettings on X, hidden on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140212/ffb482db/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list