Review Request 115639: Ensure X11 specific code is only called on platform X11

David Faure faure at kde.org
Tue Feb 11 20:17:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115639/#review49601
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 11, 2014, 7:12 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115639/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 7:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Ensure X11 specific code is only called on platform X11
> 
> Global search for HAVE_X11 in kde4support and adjusted the
> dangerous parts.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 
>   src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 
>   src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 
> 
> Diff: https://git.reviewboard.kde.org/r/115639/diff/
> 
> 
> Testing
> -------
> 
> compiles, kcolordlgtest does no longer crash on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140211/23096113/attachment.html>


More information about the Kde-frameworks-devel mailing list