Review Request 115649: Improve kdesignerplugin dependencies

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115649/#review49529
-----------------------------------------------------------

Ship it!


Good work!  Just one thing, and then you can ship it.


src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115649/#comment34930>

    I'd actually like to explicitly have KIOWidgets in this list, as there are two widgets from that library (KUrlComboRequester and KUrlRequester).


The i18n thing makes me wonder whether we should somehow generate some translations in the plugins.  I'll have to consider how that might be possible.

- Alex Merry


On Feb. 11, 2014, 10:22 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115649/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 10:22 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> -------
> 
> - Remove transitive dependencies
> - Explicitly check for more dependencies that are required
> - Do not check for KF5I18n since I cannot find anything that uses it
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 340d6d73d806e2853724960c27b9fc852e5ec2f3 
>   src/CMakeLists.txt 5b796a55395578e31c7e4b70546b36b47c557823 
> 
> Diff: https://git.reviewboard.kde.org/r/115649/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140211/abab718b/attachment.html>