Review Request 115635: Make kconfig_compiler signals actually useful

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115635/#review49505
-----------------------------------------------------------


Just a note on process: the bugfix and the unittest for that bugfix should be committed together.
Committing the test first leads to a time in history where tests don't all pass, which is bad for bisecting.
Arguably one could then commit the fix first and then the test, but that's not test-driven-development (one should check that the test does break without the fix) and it's easier when looking into old commits to see both the test and the fix.

- David Faure


On Feb. 11, 2014, 12:48 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115635/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 12:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Make kconfig_compiler signals actually useful
> 
> Previously the classes generated by kconfig_compiler would only emit
> the defined signals when using the setters provided by that class.
> However, when using e.g. KConfigDialog which uses
> KConfigSkeletonItem::setProperty() to change the items no signal was
> generated.
> This patch fixes this by using a wrapper KConfigSkeletonItem
> subclass that calls a private itemChanged() method in the generated
> class which updates the set of changed properties. As soon as the item
> is saved (usrWriteConfig() in the generated class is called) the signal
> will be emitted
> 
> 
> Diffs
> -----
> 
>   src/core/kcoreconfigskeleton.h c1a158771a785151902cd0a36aa672623618b99e 
>   src/core/kcoreconfigskeleton.cpp d9b95b4b0f236f82b1d4831432d3e7637ef19365 
>   src/kconfig_compiler/kconfig_compiler.cpp 0c4254a296348e02e596e9b10b76ff446f26bb65 
> 
> Diff: https://git.reviewboard.kde.org/r/115635/diff/
> 
> 
> Testing
> -------
> 
> Unit test from https://git.reviewboard.kde.org/r/115634/ passes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140211/0b1e1ab7/attachment-0001.html>