Review Request 115613: Drop platform name from default user agent string

[Alexander Richardson]

> On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote:
> > Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well.
> > 
> > The latest stable version of Firefox (version 27) for example sends the following user agent string by default:
> > 
> > "Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0"
> > 
> > And the latest Chromium (version 32) sends the following:
> > 
> > "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36"
> > 
> > So removing the platform name from the user-agent string might have consequences on sites that rely on it.
> 
> Martin Gräßlin wrote:
>     ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application?

Probably not very reliable, but maybe qEnvironmentVariableIsSet("DISPLAY")?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115613/#review49479
-----------------------------------------------------------


On Feb. 10, 2014, 10:15 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115613/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 10:15 a.m.)
> 
> 
> Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Drop platform name from default user agent string
> 
> The platform name (e.g. X11) was currently broken on compile time.
> On Linux it returned unknown and on all other platforms the same
> name as already included in the OS name.
> 
> We cannot really determine the platform name as this is a core
> application and the Qt's platform name is only available in a GUI
> application. Compile time is no solution as we cannot know whether
> the binary is executed on X11, Wayland, Android or whatever.
> 
> 
> Diffs
> -----
> 
>   src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 
> 
> Diff: https://git.reviewboard.kde.org/r/115613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/d4d8585b/attachment.html>