Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

[Teo Mrnjavac]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115540/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 5:35 p.m.)


Review request for KDE Frameworks and Ivan Romanov.


Changes
-------

Added explanation for #define as a comment.


Repository: qca


Description
-------

KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA.
This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4).

Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers.


Diffs (updated)
-----

  include/QtCrypto/qca_basic.h 100c626 
  include/QtCrypto/qcaprovider.h b3d40ce 

Diff: https://git.reviewboard.kde.org/r/115540/diff/


Testing
-------

Builds fine, KSecretsService links fine against it.


Thanks,

Teo Mrnjavac

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/9d552aee/attachment.html>