Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

Aleix Pol Gonzalez aleixpol at kde.org
Mon Feb 10 16:14:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115629/#review49455
-----------------------------------------------------------



drkonqi/main.cpp
<https://git.reviewboard.kde.org/r/115629/#comment34891>

    You can instantiate QApplication in the stack, instead of calling new+delete.
    
    Also you probably want to create it in the beginning of the main function body.


- Aleix Pol Gonzalez


On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115629/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Jekyll Wu.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The parsed command line values are kept in the DrKonqi singleton which
> replaces the static access to the KCmdLineArgs.
> 
> 
> Diffs
> -----
> 
>   drkonqi/drkonqi.h 95e64dc 
>   drkonqi/drkonqi.cpp ccb1c42 
>   drkonqi/drkonqibackends.cpp 064d07d 
>   drkonqi/drkonqidialog.cpp 3fc1549 
>   drkonqi/main.cpp 1337dbe 
> 
> Diff: https://git.reviewboard.kde.org/r/115629/diff/
> 
> 
> Testing
> -------
> 
> crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/8ceae6db/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list