Review Request 115606: Ommit ontologies/ dir from installing

Ivan Čukić ivan.cukic at kde.org
Mon Feb 10 10:29:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115606/#review49428
-----------------------------------------------------------

Ship it!


Commenting out is ok, but remove CMakeLists.txt from the ontologies dir as well.

The ontologies can remain to provide documentation for the relations we create later for baloo.

- Ivan Čukić


On Feb. 9, 2014, 7:58 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115606/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 7:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> So kf5 kactivities can be co-installed with kactivities4. First approach is just to comment out the dir. I don't know what are the plans, so potentially i can git rm the dir, considering the emerge of baloo with 4.13
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8a00cf8 
> 
> Diff: https://git.reviewboard.kde.org/r/115606/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/3bb5de29/attachment.html>


More information about the Kde-frameworks-devel mailing list