Review Request 115613: Drop platform name from default user agent string

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115613/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 9:15 a.m.)


Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.


Changes
-------

Adding more people for review. IMHO Dawit has final say on what the UA string should look like.


Repository: kio


Description
-------

Drop platform name from default user agent string

The platform name (e.g. X11) was currently broken on compile time.
On Linux it returned unknown and on all other platforms the same
name as already included in the OS name.

We cannot really determine the platform name as this is a core
application and the Qt's platform name is only available in a GUI
application. Compile time is no solution as we cannot know whether
the binary is executed on X11, Wayland, Android or whatever.


Diffs
-----

  src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 

Diff: https://git.reviewboard.kde.org/r/115613/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/b2ca163b/attachment.html>