Review Request 115610: Hide private method behind the d-pointer in KLineEdit

David Gil Oliva davidgiloliva at gmail.com
Sun Feb 9 23:07:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115610/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Hide private method behind the d-pointer in KLineEdit

Also:
--Move declaration of KLineEditPrivate to klineedit_p.h and leave implementation in klineedit.cpp
--For coherence, change initWidget() for init()
--Un-include headers not used

In another patch I will hide other private methods and private slots


Diffs
-----

  src/klineedit.h bea787a 
  src/klineedit.cpp 73e91df 
  src/klineedit_p.h 333135c 

Diff: https://git.reviewboard.kde.org/r/115610/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140209/35b56ff8/attachment.html>


More information about the Kde-frameworks-devel mailing list