Review Request 115586: Improve attica tests

Michael Palimaka kensington at gentoo.org
Sun Feb 9 14:49:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115586/
-----------------------------------------------------------

(Updated Feb. 9, 2014, 2:49 p.m.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: attica


Description
-------

- Use BUILD_TESTING from ECM instead of custom ATTICA_ENABLE_TESTS
- Remove enable_testing since this is done automatically by KDECMakeSettings
- Mark tests
- Remove old test that doesn't build, which tests API that no longer exists


Diffs
-----

  CMakeLists.txt 445503efba2b49546137ce1548b3ddcddb2a0ebb 
  autotests/CMakeLists.txt e4a455730fd1faddf547b6c91d4477d707f41551 
  autotests/privatedatatest.cpp e5c2d2675b1f33631f2b31a2ce0eb5db28f3406a 
  tests/projecttest/CMakeLists.txt 0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8 

Diff: https://git.reviewboard.kde.org/r/115586/diff/


Testing
-------

Builds. Tests pass when enabled, and do not run when not.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140209/08def838/attachment.html>


More information about the Kde-frameworks-devel mailing list