Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

David Gil Oliva davidgiloliva at gmail.com
Sat Feb 8 21:59:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115524/
-----------------------------------------------------------

(Updated Feb. 8, 2014, 9:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Hide a private method and a private slot of KComboBox behind the d-pointer

Also:
--Change lineEdit() for isEditable() for checking whether the kcombobox is editable.


Diffs
-----

  src/kcombobox.h e59d72b 
  src/kcombobox.cpp 2cfe6e7 

Diff: https://git.reviewboard.kde.org/r/115524/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140208/9bca60f4/attachment.html>


More information about the Kde-frameworks-devel mailing list