Review Request 115525: Deprecate slots in KCompletion and convert into slots the methods they call
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Feb 7 00:14:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115525/#review49161
-----------------------------------------------------------
Ship it!
Looks good to me
- Aleix Pol Gonzalez
On Feb. 6, 2014, 11:09 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115525/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 11:09 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Deprecate three slots (slotFoo()) that the only thing they do is call another method (foo())
>
>
> Diffs
> -----
>
> src/kcompletion.h 2104f1b
>
> Diff: https://git.reviewboard.kde.org/r/115525/diff/
>
>
> Testing
> -------
>
> It builds and tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140207/48f105da/attachment.html>
More information about the Kde-frameworks-devel
mailing list