Review Request 115481: Improve knotifyconfig dependencies

[Michael Palimaka]

> On Feb. 6, 2014, 1:44 p.m., Alex Merry wrote:
> > Before I give a ship it, I just want to check that it builds with tests disabled.  Have you already checked this?  (It'll be a couple of hours before I have a sane KF5 setup).

Yep, the default behaviour is the same, and with BUILD_TESTING=false it builds (excluding tests of course).


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115481/#review49129
-----------------------------------------------------------


On Feb. 5, 2014, 1:04 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115481/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> -------
> 
> - Remove transitive dependencies
> - Make test dependencies optional
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 78b3c717ee0eb9a4de4ebef95094f0bda00e6ef2 
>   tests/CMakeLists.txt 26a78de9e6052f650e5f6a95812dccd272dd8c4e 
> 
> Diff: https://git.reviewboard.kde.org/r/115481/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/e0932c97/attachment.html>