Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

Martin Gräßlin mgraesslin at kde.org
Thu Feb 6 13:37:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115517/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 2:37 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

added an additional check to the calling side.


Repository: kio


Description
-------

Do not crash if there is no QMimeData in decodeIsCutSelection

On Wayland the QMimeData is null and thus the Open File dialog
crashed when trying to enter a directory.


Diffs (updated)
-----

  src/filewidgets/kfilepreviewgenerator.cpp cdc18a18508eceb58b9fbcad9b68b47bf534996c 

Diff: https://git.reviewboard.kde.org/r/115517/diff/


Testing
-------

Kate on Wayland can open files now: http://paste.opensuse.org/79557635


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/ae051256/attachment.html>


More information about the Kde-frameworks-devel mailing list