Review Request 115504: Only perform tests for plugins that are built

[Alex Merry]

> On Feb. 5, 2014, 6:52 p.m., Michael Palimaka wrote:
> > CMakeLists.txt, lines 28-30
> > <https://git.reviewboard.kde.org/r/115504/diff/1/?file=242131#file242131line28>
> >
> >     Curious, what's the advantage to having a new variable vs. checking Qt5PrintSupport_FOUND later?

Well, the relationship between, say OpenEXR_FOUND and the exr plugin is pretty obvious, but the EPS plugin technically depends on (Qt5PrintSupport_FOUND AND UNIX) (although, as you note, as long as no other part of the code uses Qt5PrintSupport, just checking Qt5PrintSupport_FOUND is sufficient).  I just figured this would be easier to follow in src/ and autotests/, and avoid duplicating non-obvious tests.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/#review49066
-----------------------------------------------------------


On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115504/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 5:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Only perform tests for plugins that are built
> 
> This both excludes the autotests and tests subdirs if the user sets
> BUILD_TESTING off, and makes sure we do not run tests for formats that
> were not built due to dependencies not being found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 
>   autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
>   src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 
> 
> Diff: https://git.reviewboard.kde.org/r/115504/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/5fe54e45/attachment.html>