Review Request 115459: Introduce runtime platform support in KWindowSystem

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115459/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 10:19 a.m.)


Review request for KDE Frameworks, kdewin and Alexander Richardson.


Changes
-------

changed to pure virtual class as agateau suggested to get rid of compiler dependent macro


Repository: kwindowsystem


Description
-------

Introduce runtime platform support in KWindowSystem

This is a change similar to the one in KWindowInfo, but with variation
to the pattern due to the static container.

There is now a generic implementation of KWindowSystem which is
completely windowing system platform independent. This implementation
delegates all methods into a KWindowSystemPrivate class.

Each windowing system platform implementation needs to provide a
subclass (e.g. KWindowSystemPrivateX11) and provide all the methods
which are delegated. Note that there are no virtual methods defined,
instead the d-pointer gets casted into the proper type. Thus if a
method is not provided it will end in a compile error.

To make use of a platform implementation it needs to be included in
the ctor of KWindowSystemStaticContainer and the PlatformImplementation
enum needs to be extended by a value for the platform. This is used in
the D macro to cast and delegate correctly.

There is a dummy implementation for all not supported windowing system
platforms.

This change also includes some API changes:
* KWindowSystem::windows() returns a copy instead of const-ref
* All methods are provided, there is no longer X11 specific methods
* private methods and enums are removed

NOTE: This change breaks the implementation for Windows and Mac OS!
They are currently excluded from build.


Diffs (updated)
-----

  src/CMakeLists.txt 23133d581944a8373b9b753b300d97054b7d6f18 
  src/kwindowinfo.cpp c706b29b306b65c992a178d490819b76e1aeca84 
  src/kwindowsystem.h d288e1ab7c49f68482c94285c2aab695f08f3524 
  src/kwindowsystem.cpp PRE-CREATION 
  src/kwindowsystem_p.h PRE-CREATION 
  src/kwindowsystem_p_x11.h PRE-CREATION 
  src/kwindowsystem_x11.cpp 8d841cbcec41dc2d4df381338803902badf3f35e 

Diff: https://git.reviewboard.kde.org/r/115459/diff/


Testing
-------

Unit tests still succeed for X11, but they are not complete, though the most important aspects are tested.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/9248b526/attachment-0001.html>