Review Request 115494: Build on Mac OS X

[Bernd Buschinski]

> On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote:
> > Nope, still breaks on Linux.  I think it's because <cmath> undefs the signbit macro.
> > 
> > I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part of your request.

I would also prefer https://git.reviewboard.kde.org/r/115494/ for the math checks.

But still your patch is not invalid, as it has the struct timerval wrt thingie, so as it looks safe, I would say, for the struct stuff, ship it


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/#review49051
-----------------------------------------------------------


On Feb. 5, 2014, 4:06 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115494/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Bernd Buschinski.
> 
> 
> Repository: kjs
> 
> 
> Description
> -------
> 
> Build on Mac OS X
> 
> Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.
> 
> Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.
> 
> 
> Diffs
> -----
> 
>   src/kjs/ConfigureChecks.cmake 473da1c 
>   src/kjs/global.h.cmake d821a72 
>   src/kjs/interpreter.cpp e699651 
>   src/kjs/operations.h a54f366 
> 
> Diff: https://git.reviewboard.kde.org/r/115494/diff/
> 
> 
> Testing
> -------
> 
> It compiles again on Mac OS X :)
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/35139caf/attachment-0001.html>