Review Request 115459: Introduce runtime platform support in KWindowSystem

[Martin Gräßlin]

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote:
> > Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read.

see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I wanted to keep the same pattern.


> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote:
> > src/kwindowsystem_p_x11.h, line 106
> > <https://git.reviewboard.kde.org/r/115459/diff/1/?file=241745#file241745line106>
> >
> >     QValueList! looks like an old comment :)

of course, KWindowSystem has a copyright from 1999 :-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115459/#review48944
-----------------------------------------------------------


On Feb. 4, 2014, 9:13 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115459/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 9:13 a.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Alexander Richardson.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Introduce runtime platform support in KWindowSystem
> 
> This is a change similar to the one in KWindowInfo, but with variation
> to the pattern due to the static container.
> 
> There is now a generic implementation of KWindowSystem which is
> completely windowing system platform independent. This implementation
> delegates all methods into a KWindowSystemPrivate class.
> 
> Each windowing system platform implementation needs to provide a
> subclass (e.g. KWindowSystemPrivateX11) and provide all the methods
> which are delegated. Note that there are no virtual methods defined,
> instead the d-pointer gets casted into the proper type. Thus if a
> method is not provided it will end in a compile error.
> 
> To make use of a platform implementation it needs to be included in
> the ctor of KWindowSystemStaticContainer and the PlatformImplementation
> enum needs to be extended by a value for the platform. This is used in
> the D macro to cast and delegate correctly.
> 
> There is a dummy implementation for all not supported windowing system
> platforms.
> 
> This change also includes some API changes:
> * KWindowSystem::windows() returns a copy instead of const-ref
> * All methods are provided, there is no longer X11 specific methods
> * private methods and enums are removed
> 
> NOTE: This change breaks the implementation for Windows and Mac OS!
> They are currently excluded from build.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem_p.h PRE-CREATION 
>   src/kwindowsystem_p_x11.h PRE-CREATION 
>   src/kwindowsystem_x11.cpp 0556ec6bff7b1b5b70018758c984906687890911 
>   src/CMakeLists.txt 23133d581944a8373b9b753b300d97054b7d6f18 
>   src/kwindowinfo.cpp 790c4458075ff0ddc22102111e2d96f8c636f0ee 
>   src/kwindowsystem.h 6c2338e28ae8bb9763dfcf14eeb239bdaebda73d 
>   src/kwindowsystem.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115459/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still succeed for X11, but they are not complete, though the most important aspects are tested.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/775b1ed8/attachment.html>