Review Request 115494: Build on Mac OS X

Harald Fernengel harry at kdevelop.org
Wed Feb 5 12:28:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kjs


Description
-------

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs
-----

  src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
  src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
  src/kjs/interpreter.cpp e6996512fdeaf3b6973261ceb9a21e343d95e4c0 
  src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
-------

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/783af54b/attachment.html>


More information about the Kde-frameworks-devel mailing list