Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

Michael Palimaka kensington at gentoo.org
Wed Feb 5 11:28:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115450/#review49009
-----------------------------------------------------------


QX11Extras is found unconditionally on non-win32 platforms. Build still fails with X11 disabled:

In function `KWindowInfo::isOnCurrentDesktop() const':
src/kwindowinfo.cpp:295: undefined reference to `KWindowSystem::currentDesktop()'

- Michael Palimaka


On Feb. 5, 2014, 7:03 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115450/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 7:03 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Fix build without KWINDOWSYSTEM_HAVE_X11
> 
> In that case QX11Info is not available and we must not use it
> 
> 
> Diffs
> -----
> 
>   src/kstartupinfo.cpp c843c2991a279a136fbccdf4e7c5ae5dd8358c0e 
> 
> Diff: https://git.reviewboard.kde.org/r/115450/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/3e69abf9/attachment.html>


More information about the Kde-frameworks-devel mailing list