Review Request 115483: Improve kmediaplayer dependencies

Michael Palimaka kensington at gentoo.org
Wed Feb 5 10:24:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115483/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 10:24 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Repository: kmediaplayer


Description
-------

- Remove transitive dependencies
- Remove KI18n dependency that is not used


Diffs
-----

  src/CMakeLists.txt bff86b41fe3187aeb69dba2df1432e4f8906b4be 
  KF5MediaPlayerConfig.cmake.in 2a4307a7598f3a512aaeca30a80fdf19a6317e6b 
  CMakeLists.txt dd56f6b7cf767fb3a093967c60dc3186830697a1 

Diff: https://git.reviewboard.kde.org/r/115483/diff/


Testing
-------

Builds. Inspected source. Tests pass.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/863432f5/attachment.html>


More information about the Kde-frameworks-devel mailing list