Review Request 115370: Fix apidox, fix code style and delete useless includes in KComboBox (KCompletion)
Alex Merry
kde at randomguy3.me.uk
Tue Feb 4 23:57:24 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115370/#review48991
-----------------------------------------------------------
Ship it!
OK, just one last thing, then it can go in
src/kcombobox.h
<https://git.reviewboard.kde.org/r/115370/#comment34594>
Ah, I meant to get rid of "An enhanced combo box" in the process. ie: replace these three lines with
@short A combo box with completion support.
- Alex Merry
On Feb. 4, 2014, 11:50 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115370/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 11:50 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Fix apidox, fix code style and delete useless includes.
>
>
> Diffs
> -----
>
> src/kcombobox.h f34d259
>
> Diff: https://git.reviewboard.kde.org/r/115370/diff/
>
>
> Testing
> -------
>
> It builds. Tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/2ad58427/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list