Review Request 115419: Split KCompletionMatches class into files of its own

David Gil Oliva davidgiloliva at gmail.com
Tue Feb 4 23:08:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 11:08 p.m.)


Review request for KDE Frameworks.


Changes
-------

Fix issues suggested by Alex Merry. Little by little I'm understanding and learning things I didn't completely understand :-D Thanks!


Repository: kcompletion


Description
-------

To make code clearer, split KCompletionMatches. 


Diffs (updated)
-----

  src/CMakeLists.txt ae4a656 
  src/kcompletion.h f197fc3 
  src/kcompletion.cpp c684727 
  src/kcompletion_p.h a8dedae 
  src/kcompletionmatches.h PRE-CREATION 
  src/kcompletionmatches.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115419/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/103c7e9f/attachment.html>


More information about the Kde-frameworks-devel mailing list