Review Request 115481: Improve knotifyconfig dependencies

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115481/#review48984
-----------------------------------------------------------



tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115481/#comment34586>

    I think a better approach is to only add the tests subdir if BUILD_TESTS is true, and use set_package_properties to say that these deps are required for tests.
    
    (This is something I think should be done across all the frameworks).


- Alex Merry


On Feb. 4, 2014, 6 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115481/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 6 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> -------
> 
> - Remove transitive dependencies
> - Make test dependencies optional
> 
> 
> Diffs
> -----
> 
>   tests/CMakeLists.txt 26a78de9e6052f650e5f6a95812dccd272dd8c4e 
>   CMakeLists.txt 12944de4780c187c0a931fdafdda404ce817e5c4 
> 
> Diff: https://git.reviewboard.kde.org/r/115481/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/e28b4eea/attachment-0001.html>