Review Request 115483: Improve kmediaplayer dependencies

Alex Merry kde at randomguy3.me.uk
Tue Feb 4 22:45:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115483/#review48983
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Feb. 4, 2014, 6:23 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115483/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 6:23 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kmediaplayer
> 
> 
> Description
> -------
> 
> - Remove transitive dependencies
> - Remove KI18n dependency that is not used
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bff86b41fe3187aeb69dba2df1432e4f8906b4be 
>   KF5MediaPlayerConfig.cmake.in 2a4307a7598f3a512aaeca30a80fdf19a6317e6b 
>   CMakeLists.txt dd56f6b7cf767fb3a093967c60dc3186830697a1 
> 
> Diff: https://git.reviewboard.kde.org/r/115483/diff/
> 
> 
> Testing
> -------
> 
> Builds. Inspected source. Tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/d187743f/attachment.html>


More information about the Kde-frameworks-devel mailing list