Review Request 115378: Resolve some FIXMEs related to MSVC and Intel
Alexander Richardson
arichardson.kde at googlemail.com
Tue Feb 4 20:50:21 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115378/#review48979
-----------------------------------------------------------
Ship it!
Looks good to me
- Alexander Richardson
On Feb. 4, 2014, 1:26 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115378/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 1:26 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Use the MSVC variable directly, instead of the compiler ID
>
> This is cleaner and easier to read.
>
> Resolve some FIXMEs related to MSVC and Intel
>
> In particular, MSVC (and Intel on Windows) have no equivalent of the
> -std flag to set the language standard, and Intel does not appear to
> produce the warnings that were disabled for MSVC.
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc
>
> Diff: https://git.reviewboard.kde.org/r/115378/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/0a423b42/attachment.html>
More information about the Kde-frameworks-devel
mailing list