Review Request 115472: fix test for icon path

Alex Merry kde at randomguy3.me.uk
Tue Feb 4 17:07:40 UTC 2014



> On Feb. 4, 2014, 4:51 p.m., Jonathan Riddell wrote:
> > I realise I've largely ignored your suggestion, I think my way is more readable but if you disagree I'll go with yours
> >

FWIW, I find your way easier to parse.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115472/#review48950
-----------------------------------------------------------


On Feb. 4, 2014, 4:30 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115472/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> QPlatformTheme::IconThemeSearchPaths is ~/.icons in this Kubuntu install so fix test to allow for this
> 
> 
> Diffs
> -----
> 
>   autotests/kdeplatformtheme_unittest.cpp 2f9943f 
> 
> Diff: https://git.reviewboard.kde.org/r/115472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/107ac81b/attachment.html>


More information about the Kde-frameworks-devel mailing list