Review Request 115472: fix test for icon path
Aurélien Gâteau
agateau at kde.org
Tue Feb 4 16:02:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115472/#review48940
-----------------------------------------------------------
autotests/kdeplatformtheme_unittest.cpp
<https://git.reviewboard.kde.org/r/115472/#comment34560>
To make it more explicit, I suggest something like this:
QString name = iconPath.section(QLatin1String("/"), -1);
QVERIFY(name == QLatin1String("icons") || name == QLatin1String(".icons"));
- Aurélien Gâteau
On Feb. 4, 2014, 3:39 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115472/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 3:39 p.m.)
>
>
> Review request for KDE Frameworks and Àlex Fiestas.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> QPlatformTheme::IconThemeSearchPaths is ~/.icons in this Kubuntu install so fix test to allow for this
>
>
> Diffs
> -----
>
> autotests/kdeplatformtheme_unittest.cpp 2f9943f
>
> Diff: https://git.reviewboard.kde.org/r/115472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/e1546fd5/attachment.html>
More information about the Kde-frameworks-devel
mailing list