Review Request 115474: Use find_dependency() for attica in the Config.cmake file

Aurélien Gâteau agateau at kde.org
Tue Feb 4 15:53:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115474/#review48939
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On Feb. 4, 2014, 4:13 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115474/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Use find_dependency() for attica in the Config.cmake file
> 
> Either KXmlGui needs it or not; the feature info just confuses the
> output of other projects that depend on KXmlGui.
> 
> 
> Diffs
> -----
> 
>   KF5XmlGuiConfig.cmake.in b6c307a2d579d6b7bedf079017563030af8fdfdd 
> 
> Diff: https://git.reviewboard.kde.org/r/115474/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs; kmediaplayer (which depends on kxmlgui) configures, builds and installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/19733746/attachment.html>


More information about the Kde-frameworks-devel mailing list