Review Request 115473: information in README on each part of this framework

Alex Merry kde at randomguy3.me.uk
Tue Feb 4 14:58:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115473/#review48923
-----------------------------------------------------------


I would suggest putting the new content under another level 2 header, say ## Components

Also, is there a reason for the single-space indentation?


README.md
<https://git.reviewboard.kde.org/r/115473/#comment34549>

    Given the generic name of the plugin, I suspect that this is intended to be for the frameworks what the platform plugins are for Qt.  The text should probably reflect that.


- Alex Merry


On Feb. 4, 2014, 2:45 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115473/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 2:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This framework is made up of various unrelated parts.  Add information to README.md on each one.  This will help developers and packagers.
> 
> 
> Diffs
> -----
> 
>   README.md c798e63 
> 
> Diff: https://git.reviewboard.kde.org/r/115473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/3b7d4c17/attachment.html>


More information about the Kde-frameworks-devel mailing list