Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types
Martin Gräßlin
mgraesslin at kde.org
Tue Feb 4 13:12:33 UTC 2014
> On Feb. 4, 2014, 2 p.m., Alex Merry wrote:
> > src/kwindowsystem.h, line 596
> > <https://git.reviewboard.kde.org/r/115442/diff/2/?file=241732#file241732line596>
> >
> > Not changing this? Or deprecating it and adding another version?
I had asked for opinions in last weeks frameworks meeting and it was said it's better to not change the signals. I plan to deprecate them and add better ones, but that's a secondary step
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115442/#review48912
-----------------------------------------------------------
On Feb. 4, 2014, 7:52 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115442/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 7:52 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> Introduce QFlags for NET::Action
>
> API of NETWinInfo adjusted.
>
> Introduce QFlags for NET::State
>
> API in NET* classes and KWindowInfo and KWindowSystem adjusted.
>
> Introduce QFlags for NET::WindowTypeMasks
>
> API in NET* classes and KWindowInfo is adjusted to make use
> of the new Type instead of using long values.
>
> Introduce QFlags for NET::Property and NET::Property2
>
> API of KWindowInfo is adjusted to take NET::Properties and
> NET::Properties2 as arguments instead of usigned long int.
>
> The ctors of the NET* classes are adjusted which just take
> NET::Properties. The other ctors take the properties array
> which needs further adjustements first.
>
> In addition a WMAllProperties and WM2AllProperties enum value
> is declared to simplify matching all properties.
>
>
> Diffs
> -----
>
> src/kwindowinfo_x11.cpp eda31f2d94e23b1dd411a40fd65e96f65c389ac0
> src/kwindowsystem.h 6c2338e28ae8bb9763dfcf14eeb239bdaebda73d
> src/kwindowsystem_mac.cpp d20fbbb8c1908caa108d27e2015742b2fd14695a
> src/kwindowsystem_win.cpp cd6d4aa66e28769d595aeb40d79376f8196fde59
> src/kwindowsystem_x11.cpp 0556ec6bff7b1b5b70018758c984906687890911
> src/netwm.h 393a29de3153a8b291b9fb249bd3eaeb1ba4e7d5
> src/netwm.cpp 84eb137492e0afaaac80e8d26561fd8f8aff9c27
> src/netwm_def.h 8b1ccb8bd731aefb9559c8f2b450337b0312ed4d
> src/netwm_p.h 41792b330f7405034f4d51fb31a4de5dd674b6d0
> autotests/kwindowinfox11test.cpp 18cfe39288c280ee9a6afb7b8565215365b114d1
> autotests/netwininfotestclient.cpp 77b3ab163dcb2bf8a9d0aaf8dd0c7410865ceeca
> autotests/netwininfotestwm.cpp 585994fa0cafe63ea88beabe32bf4c73b095b3f1
> src/kwindowinfo.h 36cbbcfede41e00f9c0aaa5ee38bc3708065ffd4
> src/kwindowinfo.cpp 790c4458075ff0ddc22102111e2d96f8c636f0ee
> src/kwindowinfo_p.h 1ad6cf89e6e9dd8b070d0167410a1a758594f734
> src/kwindowinfo_p_x11.h a74ea32aa51407d0a168dd807c29787ce856f2af
>
> Diff: https://git.reviewboard.kde.org/r/115442/diff/
>
>
> Testing
> -------
>
> Unit tests still succeed.
>
> Test compiled KWin, it needs adjustments but only where int values are used (e.g. passing 0).
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/7128580e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list