Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115378/#review48880
-----------------------------------------------------------



kde-modules/KDECompilerSettings.cmake
<https://git.reviewboard.kde.org/r/115378/#comment34514>

    I think they are disabled by default, since I keep getting warnings that EHsc is missing whenever some STL headers are included.
    
    I think "/EH-" should disable exception handling if we don't want to rely on default behaviour (http://msdn.microsoft.com/en-us/library/1deeycx5.aspx)


- Alexander Richardson


On Jan. 29, 2014, 5:34 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115378/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 5:34 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Andrius da Costa Ribas.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Use the MSVC variable directly, instead of the compiler ID
> 
> This is cleaner and easier to read.
> 
> Resolve some FIXMEs related to MSVC and Intel
> 
> In particular, MSVC (and Intel on Windows) have no equivalent of the
> -std flag to set the language standard, and Intel does not appear to
> produce the warnings that were disabled for MSVC.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 92d1f823f0b257a828b3acc98e77f386dd587ff2 
> 
> Diff: https://git.reviewboard.kde.org/r/115378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/77d223f8/attachment-0001.html>