Review Request 115418: Hide private methods of KCompletion into d-pointer

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115418/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 12:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Hide private methods into d-pointer. Convert d-pointer to a QScopedPointer. 

There are still things to do next:
-Rename d-pointer member variable names: d->myCurrentMatch to d->currentMatch
-Move KCompletionPrivate declaration to kcompletion_p.h


Diffs
-----

  src/kcompletion.cpp 9d727f8 
  src/kcompletion.h fa0731e 

Diff: https://git.reviewboard.kde.org/r/115418/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140204/385b8738/attachment.html>