Review Request 115203: Allow compiling with MSVC
Alex Merry
kde at randomguy3.me.uk
Mon Feb 3 22:04:01 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48869
-----------------------------------------------------------
Ship it!
Just one thing, then it can go in.
src/kcrash.cpp
<https://git.reviewboard.kde.org/r/115203/#comment34507>
This comment is no longer correct now that the function is not at the end of the file. It should say something like "the following function is copy&pasted from kinit/wrapper.cpp"
- Alex Merry
On Feb. 3, 2014, 6:43 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 6:43 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcrash
>
>
> Description
> -------
>
> Allow compiling with MSVC
>
>
> Diffs
> -----
>
> src/kcrash.cpp 1510dc5279b502411a6b0bcafa3e614e42b32c57
> src/strlcpy-fake.c 8a6146c077bbee9fa7c4cca036eeec05dcdc4ea8
>
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140203/955e5e64/attachment.html>
More information about the Kde-frameworks-devel
mailing list