Review Request 115418: Hide private methods of KCompletion into d-pointer

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115418/#review48822
-----------------------------------------------------------

Ship it!


There is a small conflict with KCompletionPrivate declaration, but once fixed it builds successfully.

- Aurélien Gâteau


On Jan. 31, 2014, 11:40 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115418/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 11:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide private methods into d-pointer. Convert d-pointer to a QScopedPointer. 
> 
> There are still things to do next:
> -Rename d-pointer member variable names: d->myCurrentMatch to d->currentMatch
> -Move KCompletionPrivate declaration to kcompletion_p.h
> 
> 
> Diffs
> -----
> 
>   src/kcompletion.cpp 9d727f8 
>   src/kcompletion.h fa0731e 
> 
> Diff: https://git.reviewboard.kde.org/r/115418/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140203/068c1544/attachment.html>