Review Request 115434: Deprecate KWindowSystem::windowInfo

Aurélien Gâteau agateau at kde.org
Mon Feb 3 12:33:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115434/#review48820
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On Feb. 2, 2014, 12:37 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115434/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 12:37 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Deprecate KWindowSystem::windowInfo
> 
> It is just a delegate to the KWindowInfo ctor and thus duplicated
> functionality.
> 
> KWindowInfo info = KWindowInfo(w, props, props2);
> 
> is doing exactly the same as:
> 
> KWindowInfo info = KWindowSystem::windowInfo(w, props, props2);
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem_x11.cpp 01c78c1debf95d5a176e2153139da19abf383c41 
>   src/kwindowsystem_win.cpp 96148b2d808396a3046204e55fd19d767db017c5 
>   src/kwindowsystem_mac.cpp 8bd2ac763fa26ba49e7733fc3ba93e755383928c 
>   src/kwindowsystem.h 3de0fea179dd468a78a265808fc64704027ec30d 
> 
> Diff: https://git.reviewboard.kde.org/r/115434/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140203/53704bc7/attachment.html>


More information about the Kde-frameworks-devel mailing list