Review Request 115424: Improve kparts dependencies
David Faure
faure at kde.org
Sun Feb 2 09:36:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review48758
-----------------------------------------------------------
tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115424/#comment34420>
There's never any reason for the tests/ subdir to use Qt5Test.
Qt5Test = library for autotests.
- David Faure
On Feb. 1, 2014, 6:28 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115424/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2014, 6:28 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> - QtNetwork is not used
> - QtTest is only required for tests
> - Remove transitive dependencies
>
>
> Diffs
> -----
>
> tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810
> autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9
> CMakeLists.txt fe6de305d28c2cd073ae1bc5d171f1244d2ed29c
>
> Diff: https://git.reviewboard.kde.org/r/115424/diff/
>
>
> Testing
> -------
>
> Inspection of source. Builds. Tests pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140202/d52e2353/attachment.html>
More information about the Kde-frameworks-devel
mailing list