Find dependencies quietly?

Stephen Kelly steveire at gmail.com
Sun Feb 2 07:27:13 UTC 2014


On 02/02/2014 12:45 AM, Alex Merry wrote:
> On 01/02/14 20:21, Stephen Kelly wrote:
>> On 02/01/2014 08:22 PM, Alex Merry wrote:
>>> So, I think that find_dependency should pass QUIET to find_package
>>> whether or not the parent package is being found quietly.
>>>
>>> Do other people agree?
>> I agree with the problem statement, but not the solution proposed. I
>> don't think finding all dependencies QUIETly makes sense. That has other
>> side-effects.
>>
>> Did you/will you consider changing the feature_summary implementation to
>> filter them out another way? How does feature summary work? Can the
>> find_dependency macro somehow omit entries from feature_summary?
>> (without affecting other direct find_package calls?
> That makes sense.
>
> The obvious thing to do is set a package property (or something
> equivalent) that says it was found as a dependency.  The danger there is
> that if something is first found as a dependency and then found
> explicitly, it will be supressed.  We could minimise that by also
> checking that the TYPE and PURPOSE package properties were not set.

What I was getting at is a new TRANSITIVE_DEPEND package TYPE.

Existing docs:

#     SET_PACKAGE_PROPERTIES(<name> PROPERTIES [ URL <url> ]
#                                              [ DESCRIPTION <description> ]
#                                              [ TYPE
(RUNTIME|OPTIONAL|RECOMMENDED|REQUIRED) ]

# If set_package_properties() is called multiple times for the same
# package with different TYPEs, the TYPE is only changed to higher TYPEs
# ( RUNTIME < OPTIONAL < RECOMMENDED < REQUIRED ),

Investigate whether what you want is a separate, similar logic which can
'upgrade' a TRANSITIVE_DEPEND to REQUIRED. Separate because (RECOMMENDED
< TRANSITIVE_DEPEND) is not true.

Thanks,

Steve.



More information about the Kde-frameworks-devel mailing list