Review Request 115430: Add simple autotests

Sun Feb 2 03:11:42 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115430/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kimageformats

Description
-------

Add simple autotests

Two main tests: read the file and compare to a given image (loaded from
png), and write a file out and compare to a previously-written image.

The write test in particular is kind of fragile, but it should help
catch some errors where a code change was not intended to affect the
output of the plugin.

Tests are included for all the writable formats, as well as every
readable format that GIMP can write to (and so I could easily get an
example of).

Diffs
-----

  autotests/write/rgb.png PRE-CREATION 
  autotests/write/rgb.rgb PRE-CREATION 
  autotests/write/rgb.tga PRE-CREATION 
  autotests/write/rgb.xv PRE-CREATION 
  autotests/write/rgba.pic PRE-CREATION 
  autotests/write/rgba.png PRE-CREATION 
  autotests/write/rgba.tga PRE-CREATION 
  autotests/write/rgba.xv PRE-CREATION 
  autotests/writetest.cpp PRE-CREATION 
  tests/CMakeLists.txt b57287b94cc4c6f108737a3dc8831eecac57cf40 
  autotests/read/xv/rgb.xv PRE-CREATION 
  autotests/read/xv/rgb.png PRE-CREATION 
  autotests/read/xv/bw.xv PRE-CREATION 
  autotests/read/xv/bw.png PRE-CREATION 
  autotests/read/xcf/simple-rgba-gimp-2.8.10.xcf PRE-CREATION 
  autotests/read/xcf/simple-rgba-gimp-2.8.10.png PRE-CREATION 
  autotests/read/xcf/simple-rgb-gimp-2.8.10.xcf PRE-CREATION 
  autotests/read/xcf/simple-rgb-gimp-2.8.10.png PRE-CREATION 
  autotests/read/xcf/simple-bwa-gimp-2.8.10.xcf PRE-CREATION 
  autotests/read/xcf/simple-bwa-gimp-2.8.10.png PRE-CREATION 
  autotests/read/xcf/simple-bw-gimp-2.8.10.xcf PRE-CREATION 
  autotests/read/xcf/simple-bw-gimp-2.8.10.png PRE-CREATION 
  autotests/read/tga/rgba.tga PRE-CREATION 
  autotests/read/tga/rgba.png PRE-CREATION 
  autotests/read/tga/rgb.tga PRE-CREATION 
  autotests/read/tga/rgb.png PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-top-left.tga PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-top-left.png PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-rle-top-left.tga PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-rle-top-left.png PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-rle-bottom-left.tga PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-rle-bottom-left.png PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-bottom-left.tga PRE-CREATION 
  autotests/read/tga/rgb-gimp-2.8.10-bottom-left.png PRE-CREATION 
  autotests/read/tga/bwa.png PRE-CREATION 
  autotests/read/tga/bwa.tga PRE-CREATION 
  autotests/read/tga/bw.tga PRE-CREATION 
  autotests/read/tga/bw.png PRE-CREATION 
  autotests/read/rgb/rgb.rgb PRE-CREATION 
  autotests/read/rgb/rgb.png PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-uncompressed.rgb PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-uncompressed.png PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-rle.rgb PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-rle.png PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-aggressive-rle.rgb PRE-CREATION 
  autotests/read/rgb/rgb-gimp-2.8.10-aggressive-rle.png PRE-CREATION 
  autotests/read/rgb/bw.rgb PRE-CREATION 
  autotests/read/rgb/bw.png PRE-CREATION 
  autotests/read/pcx/bw.png PRE-CREATION 
  autotests/read/pcx/rgb-gimp-2.8.10.pcx PRE-CREATION 
  autotests/read/pcx/rgb-gimp-2.8.10.png PRE-CREATION 
  autotests/read/pcx/rgb.pcx PRE-CREATION 
  autotests/read/pcx/rgb.png PRE-CREATION 
  autotests/read/pic/bw.pic PRE-CREATION 
  autotests/read/pic/bw.png PRE-CREATION 
  autotests/read/pic/bwa.pic PRE-CREATION 
  autotests/read/pic/bwa.png PRE-CREATION 
  autotests/read/pic/rgb.pic PRE-CREATION 
  autotests/read/pic/rgb.png PRE-CREATION 
  autotests/read/pic/rgba.pic PRE-CREATION 
  autotests/read/pic/rgba.png PRE-CREATION 
  autotests/read/psd/rgb-gimp-2.8.10.png PRE-CREATION 
  autotests/read/psd/rgb-gimp-2.8.10.psd PRE-CREATION 
  autotests/read/ras/rgb-gimp-2.8.10-standard.png PRE-CREATION 
  autotests/read/ras/rgb-gimp-2.8.10-standard.ras PRE-CREATION 
  autotests/write/rgb.pic PRE-CREATION 
  autotests/write/rgb.pcx PRE-CREATION 
  autotests/write/rgb.jp2 PRE-CREATION 
  autotests/write/rgb.eps PRE-CREATION 
  autotests/write/bwa.xv PRE-CREATION 
  autotests/write/bwa.tga PRE-CREATION 
  autotests/write/bwa.png PRE-CREATION 
  autotests/write/bwa.pic PRE-CREATION 
  autotests/write/bw.xv PRE-CREATION 
  autotests/write/bw.tga PRE-CREATION 
  autotests/write/bw.rgb PRE-CREATION 
  autotests/write/bw.png PRE-CREATION 
  autotests/write/bw.pic PRE-CREATION 
  autotests/write/bw.pcx PRE-CREATION 
  autotests/write/bw.jp2 PRE-CREATION 
  autotests/write/bw.eps PRE-CREATION 
  autotests/readtest.cpp PRE-CREATION 
  autotests/read/pcx/bw.pcx PRE-CREATION 
  autotests/read/jp2/rgb.png PRE-CREATION 
  autotests/read/jp2/rgb.jp2 PRE-CREATION 
  autotests/read/jp2/bw.png PRE-CREATION 
  autotests/read/jp2/bw.jp2 PRE-CREATION 
  autotests/read/eps/rgb.png PRE-CREATION 
  autotests/read/eps/rgb.eps PRE-CREATION 
  autotests/read/eps/rgb-gimp-2.8.10.png PRE-CREATION 
  autotests/read/eps/rgb-gimp-2.8.10.eps PRE-CREATION 
  CMakeLists.txt df7d02f379c5cd0e8040d4286701eb8cdc9f68ee 
  autotests/CMakeLists.txt PRE-CREATION 
  autotests/read/eps/bw.eps PRE-CREATION 
  autotests/read/eps/bw.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115430/diff/

Testing
-------

Tests build and pass.

Reference images PNG images are correct by inspection (checked with Gwenview on KDE 4).

Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140202/18fd2f37/attachment.html>