Review Request 115419: Split KCompletionMatches declaration from kcompletion.h into own header file

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/#review48744
-----------------------------------------------------------


If this is going to be split, I think the KCompletionMatches implementation should also go in its own kcompletionmatches.cpp file.


src/kcompletion.h
<https://git.reviewboard.kde.org/r/115419/#comment34412>

    This needs to move to the other header.


- Alex Merry


On Feb. 1, 2014, 11:02 a.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115419/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2014, 11:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> To make kcompletion.h smaller, split KCompletionMatches into own header file
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ae4a656 
>   src/kcompletion.h f197fc3 
>   src/kcompletion.cpp c684727 
>   src/kcompletionmatches.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115419/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140201/d5d5e67d/attachment.html>