Review Request 121773: Fix build without X.

Jeremy Whiting jpwhiting at kde.org
Wed Dec 31 12:52:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121773/#review72841
-----------------------------------------------------------



src/kdesud/kdesud.cpp
<https://git.reviewboard.kde.org/r/121773/#comment50720>

    Why not use if HAVE_X11 && !defined(Q_OS_MAC) to keep that fix in place?


- Jeremy Whiting


On Dec. 31, 2014, 3:23 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121773/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 3:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> -------
> 
> This fixes breakage introduced by 5de62b90fdaece5555965876af8f991d48640f21
> since HAVE_X11 is always defined (0 or 1), and reverts 163d9f1598596cfe8090f21c2562e25e64ad151b
> since it's just a workaround for OSX for the aforementioned breakage.
> 
> 
> Diffs
> -----
> 
>   src/kdesud/kdesud.cpp 337e37a50b9d10ae8c0839f6d26e67de6a9418d9 
> 
> Diff: https://git.reviewboard.kde.org/r/121773/diff/
> 
> 
> Testing
> -------
> 
> Build passes again, both with and without X.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141231/5bfdefc3/attachment.html>


More information about the Kde-frameworks-devel mailing list