Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

[David Faure]

> On Dec. 30, 2014, 12:05 a.m., Aleix Pol Gonzalez wrote:
> > autotests/kfiledialog_unittest.cpp, line 150
> > <https://git.reviewboard.kde.org/r/121747/diff/1/?file=337144#file337144line150>
> >
> >     switch()? Use QStringLiteral?

Done. This was taken from kfile.cpp, which has if()s.


> On Dec. 30, 2014, 12:05 a.m., Aleix Pol Gonzalez wrote:
> > autotests/kfiledialog_unittest.cpp, line 159
> > <https://git.reviewboard.kde.org/r/121747/diff/1/?file=337144#file337144line159>
> >
> >     Are you sure this builds? I thought QString(char* ) wasn't allowed in frameworks.

Well, it's "allowed" when this is being done:
autotests/CMakeLists.txt: remove_definitions(-DQT_NO_CAST_FROM_ASCII)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121747/#review72758
-----------------------------------------------------------


On Dec. 29, 2014, 10:38 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121747/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 10:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Commit 0b8ab82e7fa9ea0948a841ebf8523b62da made the view mode a choice of
> the user (as it always was in KDE code) rather than a choice of the
> developer (as QFileDialog::setViewMode allows).
> 
> Typical Qt/KDE difference: Qt empowers the developer, KDE empowers the user.
> I agree with Lukas that the latter makes more sense in KDE code.
> 
> => I rewrote the unittest to check that the user's changes are restored
> on the next file dialog.
> 
> 
> Diffs
> -----
> 
>   autotests/kfiledialog_unittest.cpp e5108ead5a381864cfa2b8ddf62b5d6c64b13db9 
> 
> Diff: https://git.reviewboard.kde.org/r/121747/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141231/0c6d2a30/attachment-0001.html>