Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

Alex Richardson arichardson.kde at gmail.com
Mon Dec 29 19:30:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/
-----------------------------------------------------------

(Updated Dez. 29, 2014, 7:30 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Remove the conversion code below and reuse KPluginInfoPrivate::setMetaData()


Repository: kservice


Description
-------

This should fix property() returning empty QVariants even if it
existed in the .desktop file


Diffs (updated)
-----

  src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa66667961d68b16 

Diff: https://git.reviewboard.kde.org/r/121737/diff/


Testing
-------

KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value.


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141229/b2d14845/attachment.html>


More information about the Kde-frameworks-devel mailing list