Review Request 121081: QT_WA
David Faure
faure at kde.org
Sun Dec 28 22:24:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/#review72633
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Nov. 8, 2014, 10:27 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121081/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 10:27 p.m.)
>
>
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> QT_WA is not available on Qt5. We also only use the Unicode version, anyways.
>
>
> Diffs
> -----
>
> lib/konq/src/konq_copytomenu.cpp 7f97c12
>
> Diff: https://git.reviewboard.kde.org/r/121081/diff/
>
>
> Testing
> -------
>
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141228/5bad0ddd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list