Review Request 121672: Properly convert .desktop files that have an associated servicetype

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121672/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
-------

This ensures that properties that are defined to be of type QStringList
or int or bool are properly converted to the right JSON type.

Not sure if this code should also be part of KF5CoreAddons.so, since it
does increase the library size quite a bit. It would however be very
useful for kcoreaddons_desktop_to_json(), so that the initial conversion
to JSON does not have to be done by hand.

I probably don't have all the service types that exist installed on my
system so I might be missing some properties. I included the script to
generate the list of these properties, so that missing properties can
be added by anyone who has the required servicetypes/*.desktop files
installed.


Diffs
-----

  src/lib/plugin/read-servicetypes.py PRE-CREATION 
  autotests/desktoptojsontest.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd 
  src/lib/plugin/desktopfileparser.cpp b1b5440b48e4fd412932a7d7e794d641b1406699 

Diff: https://git.reviewboard.kde.org/r/121672/diff/


Testing
-------

Unit test works


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141226/754d60f5/attachment.html>