OSX/CI: kio placed files erroneously due to missing required backslash in path

Marko Käning mk-lists at email.de
Mon Dec 22 23:59:56 UTC 2014


Hi,

on OSX it looks like some app places files directly in "~/Library", as it misses to insert a backslash in between the standard location "~/Library/Application Support” and the 3 files (user-places.xbel*) to be generated in there:
---
$ ls -l1 Library/Application\ Supportuser-places.xbel*
-rw------- 1 marko staff 245 Dec 10 03:23 Library/Application Supportuser-places.xbel
-rw------- 1 marko staff 512 Dec 10 03:23 Library/Application Supportuser-places.xbel.bak
-rw------- 1 marko staff   0 Dec 10 03:23 Library/Application Supportuser-places.xbel.tbcache
---

Grep-ing the whole code base to figure out which app caused this shows:
---
$ find WC/KDECI-builds/ -name "*.cpp" -exec grep -H user-places.xbel {} \;
WC/KDECI-builds/kbookmarks/autotests/kbookmarktest.cpp:    const QString placesFile = datadir + "/user-places.xbel";
WC/KDECI-builds/kio/src/filewidgets/kfileplacesmodel.cpp:    // ~/.local/share/user-places.xbel (according to freedesktop bookmarks spec), and
WC/KDECI-builds/kio/src/filewidgets/kfileplacesmodel.cpp:        // user-places.xbel will be filled later). (ereslibre)
WC/KDECI-builds/kio/src/filewidgets/kfileplacessharedbookmarks.cpp:    const QString file = datadir + "user-places.xbel";
—--
where the last line reveals the culprit as being kio!

	Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50

Ooops, should I have pushed this through Gerrit before committing?

Greets,
Marko


More information about the Kde-frameworks-devel mailing list