Review Request 121581: Plotter in kdeclarative

Marco Martin notmart at gmail.com
Mon Dec 22 12:27:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/
-----------------------------------------------------------

(Updated Dec. 22, 2014, 12:27 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

on kquickcontrolsaddons plugin in order to not depend from kxmlgui
findepoxy is local for now, before making it work under window too (and move it to ECM)


Repository: kdeclarative


Description
-------

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/

since the plotter component doesn't depend from libplasma, it may be useful to have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION 
  CMakeLists.txt 233ccce 
  cmake/Findepoxy.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121581/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141222/acb38c7a/attachment.html>


More information about the Kde-frameworks-devel mailing list